Remove some unnecessary dynamic vectors/strings #7862
+27
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernative. Code tweak in prepareForEvaluation to use logical OR rather than bitwise and const the initial bool variable.
|
So this change is in the first half correct but I'm not sure I like it. Naming that white list and table set makes the code quite a bit clearer i thought. The second change to a constexpr initializer list is, I think, a c++ 20 thing. At least it doesn't compile in ci with clang for mac. |
|
That whitelist should've been behind a |
added 2 commits
November 21, 2024 21:30
More ref usage. 2 functions can be static.
|
How's this one looking now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate dynamic vector & string storage where there's a simpler alternative.
Code tweak in prepareForEvaluation to use logical OR rather than bitwise and const the initial bool variable.