Move Nimbus from libsamplerate to our Lanczos downsampler #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Makes it ready to move to sst-effects 2. Makes it so we can almost remove libsamplerate (but some twist smidgeof work to do that) 3. Uses less CPU Addresses surge-synthesizer#7359
|
Does this mean we can remove libsamplerate from our list of deps? |
|
Ha. See the plan I just posted on discord I wanted to do it as a separate step for bisect reasons but "yes" |
|
For GitHub folks who find this issue this was the discord comment Doing a bit of surge / effects / shortcircuit combined work. Moving away from the libsamplerate (SRC) dependency. It's a bit multi step step one - port Nimbus from SRC to Lanczos. That's done and a PR is in |
nuoun
added a commit
to nuoun/surge
that referenced
this pull request
Aug 3, 2024
Clang Format add "global" table to Lua state plus redo voice data for formula editor Default sandbox functions Add back "global" table clear in setSurgeFunctionEnvironment() Add stack test squash Fix segfault in testrunner clang format Move Nimbus from libsamplerate to our Lanczos downsampler (surge-synthesizer#7726) 1. Makes it ready to move to sst-effects 2. Makes it so we can almost remove libsamplerate (but some twist smidgeof work to do that) 3. Uses less CPU Addresses surge-synthesizer#7359 Remove libsamplerate dependency (surge-synthesizer#7728) After porting Nimbus ot lanczos in 4b3ffe6 we can now remove the libsamplerate dependency altogether as long as we fix up the twist fm (which we did with a simple application of another lanczos ds) and remove src code from the unit tests (where it was explicitly tested) Move Nimbus to sst-effects (surge-synthesizer#7729) * Move Nimbus to sst-effects Addresses surge-synthesizer#7359 With an almost-complete port (param name dynamism is in surge but not in the submodule yet) * f Update LFO and Step Seq presets to have the LFO EG enabled (surge-synthesizer#7732) Code Checks github action, as part one of move to actions Move to actions here will be a bit trickier, but we will get there. Step one is have any action at all, so add a code check action. Pull Request moves to Github Actions (surge-synthesizer#7733) The PullRequest support of our azure pipeline is now on GitHub actions, building in various configurations and running the tests. The azure pipeline still exists to trigger the release stage, which is what I'll port tomorrow, or maybe thursday, and then be done with the azure->actions project. - Adds voice_id, voice_max, voice_count, is_display parameters to formula modulator - Fakes voice_count of "1" and sets defaults for other params on display calls - Adds "shared" table to formula modulator - Sets entries of "shared" table to nil on new Lua function env - Makes formula debugger also use "shared" table - Adds lua_isfunction to formula debugger - Some cleanup
baconpaul
pushed a commit
to nuoun/surge
that referenced
this pull request
Aug 6, 2024
Clang Format add "global" table to Lua state plus redo voice data for formula editor Default sandbox functions Add back "global" table clear in setSurgeFunctionEnvironment() Add stack test squash Fix segfault in testrunner clang format Move Nimbus from libsamplerate to our Lanczos downsampler (surge-synthesizer#7726) 1. Makes it ready to move to sst-effects 2. Makes it so we can almost remove libsamplerate (but some twist smidgeof work to do that) 3. Uses less CPU Addresses surge-synthesizer#7359 Remove libsamplerate dependency (surge-synthesizer#7728) After porting Nimbus ot lanczos in 4b3ffe6 we can now remove the libsamplerate dependency altogether as long as we fix up the twist fm (which we did with a simple application of another lanczos ds) and remove src code from the unit tests (where it was explicitly tested) Move Nimbus to sst-effects (surge-synthesizer#7729) * Move Nimbus to sst-effects Addresses surge-synthesizer#7359 With an almost-complete port (param name dynamism is in surge but not in the submodule yet) * f Update LFO and Step Seq presets to have the LFO EG enabled (surge-synthesizer#7732) Code Checks github action, as part one of move to actions Move to actions here will be a bit trickier, but we will get there. Step one is have any action at all, so add a code check action. Pull Request moves to Github Actions (surge-synthesizer#7733) The PullRequest support of our azure pipeline is now on GitHub actions, building in various configurations and running the tests. The azure pipeline still exists to trigger the release stage, which is what I'll port tomorrow, or maybe thursday, and then be done with the azure->actions project. - Adds voice_id, voice_max, voice_count, is_display parameters to formula modulator - Fakes voice_count of "1" and sets defaults for other params on display calls - Adds "shared" table to formula modulator - Sets entries of "shared" table to nil on new Lua function env - Makes formula debugger also use "shared" table - Adds lua_isfunction to formula debugger - Some cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7359