UserInteractions defaults to OK on LInux #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OKCancel is only used to chicken box overwritign a patch. Neither default is great, but chosing OK means at least the user action is not silently ignored. Closes surge-synthesizer#749 Will be greatly improved by the correct implementation of surge-synthesizer#562
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
OKCancel is only used to chicken box overwritign a patch. Neither default is great, but chosing OK means at least the user action is not silently ignored. Closes surge-synthesizer#749 Will be greatly improved by the correct implementation of surge-synthesizer#562 Former-commit-id: ce10a4c1ba842ddc8fa92654c9505f53133db58d [formerly ee8dcca] Former-commit-id: 3d535d44f84c4fd994dbd5696470b259bc276af9 Former-commit-id: bb6df1148a16c417842da807e30636e3c8f5b626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKCancel is only used to chicken box overwritign a patch.
Neither default is great, but chosing OK means at least
the user action is not silently ignored.
Closes #749
Will be greatly improved by the correct implementation of #562