Modern Oscillator Pitch: Lag -> Lipol #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses surge-synthesizer#7224 The original version of Modern used the trailing three points for the derivative, but didnt' recaclulate all three at once. This meant it was a bit unstable under extreme pitch changes so we used a lag/lpf on pitch and dphase. We subsequently changed the algorithm to always calculate the trailing three points but never undid that lag, leading to low porta high shift having an audible sweep in modern, as reported in surge-synthesizer#7224. This change fixes that and simply block smooths pitch shifts.
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Oct 5, 2023
This reverts commit 0d099b3. The change causes pops under extrema which I will outline in the original issue
baconpaul
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #7224
The original version of Modern used the trailing three points for the derivative, but didnt' recaclulate all three at once. This meant it was a bit unstable under extreme pitch changes so we used a lag/lpf on pitch and dphase. We subsequently changed the algorithm to always calculate the trailing three points but never undid that lag, leading to low porta high shift having an audible sweep in modern, as reported in #7224.
This change fixes that and simply block smooths pitch shifts.