Modern retrig-from-zero sample offset #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modern 2-point DPW algorithm uses points at phase, phase-d and phase -2d to calculate. This has the defacto one-sample latency effect (at the oversample sample rate). This doesn't matter *except* in the retrigger-from-zero case when that shift makes the first output point at the wrong phase. So in retrigger, intiialize phase to dphase, not to 0, so you can hit the zero point for symmetric waveforms exactly. Addresses surge-synthesizer/surge-rack#937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modern 2-point DPW algorithm uses points at phase, phase-d and phase -2d to calculate. This has the defacto one-sample latency effect (at the oversample sample rate).
This doesn't matter except in the retrigger-from-zero case when that shift makes the first output point at the wrong phase.
So in retrigger, intiialize phase to dphase, not to 0, so you can hit the zero point for symmetric waveforms exactly.
Addresses surge-synthesizer/surge-rack#937