Turn off Midi PC Factory Backfill #7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially made the unused banks fill in order with Factory. We decided this was probably too volatile so just turned it off. Doing so means in most cases midi program change does nothing so also remove the menu item for ignore midi program change. Also push MIDI Programs to bottom of user list after a separator and only show it if it has contents Closes surge-synthesizer#576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially made the unused banks fill in order
with Factory. We decided this was probably too volatile so just turned it off.
Doing so means in most cases midi program change does nothing so also remove the menu item for ignore midi program change.
Closes #576