Handle latch in dual MPE and no-23 mode #7126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MPE or ignore-23-to-scene mode, turning one scene on to latch would mistakenly trigger voices in the non latched scene. Fix that but adding an intended scene optional argument to playNote and calling it from the right place. Also add a regtest. Closes surge-synthesizer#6963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MPE or ignore-23-to-scene mode, turning one scene on to latch would mistakenly trigger voices in the non latched scene. Fix that but adding an intended scene optional argument to playNote and calling it from the right place. Also add a regtest.
Closes #6963