Osc->init ignored octave; commit changes sound. #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SurgeVoice called osc->init with a pitch which ignored the octave offset and so forth. This meant that the first block of any oscillator with octave +3 would have a 3 octave immediate shift. This long lived bug (since inception) is audible in the String and Modern oscillators which have a variety of memory and smoothing in their handling of pitch. This will subtly change the sound of oscillators with high octaves, but will change it to be correct. Closes surge-synthesizer#6985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SurgeVoice called osc->init with a pitch which ignored the octave offset and so forth. This meant that the first block of any oscillator with octave +3 would have a 3 octave immediate shift.
This long lived bug (since inception) is audible in the String and (far less so) Modern oscillators which have a variety of memory and smoothing in their handling of pitch.
This will subtly change the sound of oscillators with high octaves, but will change it to be correct.
Closes #6985