Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Nightly build and CodeQual times #6970

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Improve Nightly build and CodeQual times #6970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b41c82f
Improve Nightly build and CodeQual times
baconpaul Apr 21, 2023
aa88438
f
baconpaul Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ include(cmake/stage-extra-content.cmake)
add_custom_target(code-quality-pipeline-checks)

# Check 1: The extra content is properly specified.
add_dependencies(code-quality-pipeline-checks download-extra-content)
# add_dependencies(code-quality-pipeline-checks download-extra-content)

# Clang Format checks
set(CLANG_FORMAT_DIRS src)
Expand Down
30 changes: 20 additions & 10 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,24 @@ pr:
- xt-alpha

jobs:
- job: Build
- job: BuildCodeQuality
pool:
vmImage: 'ubuntu-20.04'

steps:
- checkout: self
fetchDepth: 1
# submodules: recursive # can't do submodules here b'cuz depth=1 fails with Github

- bash: |
git submodule update --init --recursive
cmake -Bignore/cq -DSURGE_SKIP_JUCE_FOR_RACK=TRUE -DCMAKE_BUILD_TYPE=Debug -DSURGE_SKIP_LUA=TRUE
cmake --build ignore/cq --target code-quality-pipeline-checks
displayName: Do Codequal


- job: BuildForPR
condition: eq(variables['Build.Reason'], 'PullRequest')
variables:
defaultTargets: "surge-xt_Packaged surge-fx_Packaged"
strategy:
Expand Down Expand Up @@ -56,13 +73,6 @@ jobs:
cmakeArguments: "-A x64 -DCMAKE_BUILD_TYPE=Release"
cmakeConfig: "Release"
cmakeTarget: "surge-testrunner"
linux-codequality:
imageName: 'ubuntu-20.04'
isLinux: True
aptGetExtras: ""
cmakeArguments: "-GNinja -DCMAKE_BUILD_TYPE=Debug"
cmakeTarget: "code-quality-pipeline-checks"
cmakeConfig: "Debug"
linux-juce-python-targets:
imageName: 'ubuntu-22.04'
isLinux: True
Expand Down Expand Up @@ -204,8 +214,8 @@ jobs:
displayName: macOS - run unit tests

- job: NotifyReleases
dependsOn: Build
condition: succeeded()
dependsOn: BuildCodeQuality
condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')))
pool:
vmImage: 'ubuntu-20.04'

Expand Down