Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavetable and User Data Improvements #696

Merged

Conversation

baconpaul
Copy link
Collaborator

This diff implements a collection of improvements for how you
open, access, and navigate user data and third party data, especially
wavetables. It adds the following features

  1. Allows .wt files to exist in ~/Documents/Surge and appear in the
    wavetable directory

  2. Allows .wt files to exist in (surge-data-folder)/wavetables_3rdparty

  3. Gives a function to open both the factory and user data folder in your
    OS appropriate file explorer

  4. Adds subdirectory and heirarchy support to wavetables

  5. Adds the "New Vocal Wavetables for Surge" pack from Layzer as discussed
    https://www.kvraudio.com/forum/viewtopic.php?p=7313640#p7313640

This diff addresses several issues

Closes #603 : Separator to 3rd party wavetables
Closes #288 : .wt files from ~/Documents/Surge
Closes #488 : Open a user folder and factory folder from menu

@baconpaul
Copy link
Collaborator Author

@esaruoho I would love it if you could find some time to test this out to see if it does what you want. (and it only does .wt; still no .wav)

@esaruoho
Copy link
Collaborator

esaruoho commented Mar 2, 2019

first feedback:

in ~/Documents/Surge, I have a wavetables -folder with subfolders VFXTW which has subfolders VFX-OS and VFX-TW. These are not visible here:
image

now i have moved them from ~/Documents/Surge/wavetables/VFXTW/VFX-TW to wavetables/VFX-TW just to see what might happen.

image

So, sub-sub-folders are not yet accepted, but otherwise, they load. so, this is great! can ya add sub-subfolder support? otherwise this is good to go. Tested with VST2Renoise/Logic/AU,Live/VST2.

@esaruoho
Copy link
Collaborator

esaruoho commented Mar 2, 2019

anyway, lgtm! sub-sub-subfolders can be tweaked in later.

@baconpaul
Copy link
Collaborator Author

Huh sub sub folders should work; that’s a bug. I’ll give it a test and see if I can find it!

@baconpaul
Copy link
Collaborator Author

Thanks for testing!

@esaruoho
Copy link
Collaborator

esaruoho commented Mar 2, 2019

@baconpaul sub-sub-folders work.. sub-sub-sub-folders don't :)

@baconpaul
Copy link
Collaborator Author

Yeah got it. But that’s a sign of a wierd bug. i didn’t assume depth anywhere. So would like to try and figure it out!

This diff implements a collection of improvements for how you
open, access, and navigate user data and third party data, especially
wavetables. It adds the following features

1. Allows .wt files to exist in ~/Documents/Surge and appear in the
   wavetable directory

2. Allows .wt files to exist in (surge-data-folder)/wavetables_3rdparty

3. Gives a function to open both the factory and user data folder in your
   OS appropriate file explorer

4. Adds subdirectory and heirarchy support to wavetables

5. Adds the "New Vocal Wavetables for Surge" pack from Layzer as discussed
   https://www.kvraudio.com/forum/viewtopic.php?p=7313640#p7313640

6. Fix bugs reported by @esaruoho in the initial implementation

This diff addresses several issues

Closes surge-synthesizer#603 : Separator to 3rd party wavetables
Closes surge-synthesizer#288 : .wt files from ~/Documents/Surge
Closes surge-synthesizer#488 : Open a user folder and factory folder from menu
@baconpaul baconpaul force-pushed the third-party-wavetables-603 branch from 15b9514 to 5863497 Compare March 2, 2019 20:40
@baconpaul
Copy link
Collaborator Author

Oh hold on - another bug. I broke the "window" wavetable with this change. Won't merge until I fix it.

@baconpaul
Copy link
Collaborator Author

Oh no that was just a bad build. We're all good!

@esaruoho esaruoho merged commit 65db7f6 into surge-synthesizer:master Mar 3, 2019
@baconpaul baconpaul deleted the third-party-wavetables-603 branch March 11, 2019 00:26
baconpaul pushed a commit to baconpaul/surge that referenced this pull request Jul 10, 2019
…avetables-603

Wavetable and User Data Improvements

Former-commit-id: 393b8f42f5d3a192539e30aae33d57194f1f3f86 [formerly 65db7f6]
Former-commit-id: 6446d0f3297a189c1ad2e58f17a36d1dbc7de72d
Former-commit-id: 67174c938e8fa826e0992182670db62145782c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants