-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavetable and User Data Improvements #696
Wavetable and User Data Improvements #696
Conversation
@esaruoho I would love it if you could find some time to test this out to see if it does what you want. (and it only does .wt; still no .wav) |
anyway, lgtm! sub-sub-subfolders can be tweaked in later. |
Huh sub sub folders should work; that’s a bug. I’ll give it a test and see if I can find it! |
Thanks for testing! |
@baconpaul sub-sub-folders work.. sub-sub-sub-folders don't :) |
Yeah got it. But that’s a sign of a wierd bug. i didn’t assume depth anywhere. So would like to try and figure it out! |
This diff implements a collection of improvements for how you open, access, and navigate user data and third party data, especially wavetables. It adds the following features 1. Allows .wt files to exist in ~/Documents/Surge and appear in the wavetable directory 2. Allows .wt files to exist in (surge-data-folder)/wavetables_3rdparty 3. Gives a function to open both the factory and user data folder in your OS appropriate file explorer 4. Adds subdirectory and heirarchy support to wavetables 5. Adds the "New Vocal Wavetables for Surge" pack from Layzer as discussed https://www.kvraudio.com/forum/viewtopic.php?p=7313640#p7313640 6. Fix bugs reported by @esaruoho in the initial implementation This diff addresses several issues Closes surge-synthesizer#603 : Separator to 3rd party wavetables Closes surge-synthesizer#288 : .wt files from ~/Documents/Surge Closes surge-synthesizer#488 : Open a user folder and factory folder from menu
15b9514
to
5863497
Compare
Oh hold on - another bug. I broke the "window" wavetable with this change. Won't merge until I fix it. |
Oh no that was just a bad build. We're all good! |
…avetables-603 Wavetable and User Data Improvements Former-commit-id: 393b8f42f5d3a192539e30aae33d57194f1f3f86 [formerly 65db7f6] Former-commit-id: 6446d0f3297a189c1ad2e58f17a36d1dbc7de72d Former-commit-id: 67174c938e8fa826e0992182670db62145782c21
This diff implements a collection of improvements for how you
open, access, and navigate user data and third party data, especially
wavetables. It adds the following features
Allows .wt files to exist in ~/Documents/Surge and appear in the
wavetable directory
Allows .wt files to exist in (surge-data-folder)/wavetables_3rdparty
Gives a function to open both the factory and user data folder in your
OS appropriate file explorer
Adds subdirectory and heirarchy support to wavetables
Adds the "New Vocal Wavetables for Surge" pack from Layzer as discussed
https://www.kvraudio.com/forum/viewtopic.php?p=7313640#p7313640
This diff addresses several issues
Closes #603 : Separator to 3rd party wavetables
Closes #288 : .wt files from ~/Documents/Surge
Closes #488 : Open a user folder and factory folder from menu