Check for LATO built in #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than try and runtime load the Lato font assume it is installed and react accordingly if it is not. No longer bundle it with the dll and instead bundle it with the installer. Closes surge-synthesizer#678 : Font causes Hang on some Windows Closes surge-synthesizer#673 : De-Bold our Lato
|
I tested this several ways, including checking if Lato installed when I ran the installer, running the installer twice to make sure the second install worked, etc... Would really appreciate an eyeball from @kzantow on those iss changes The rest of it makes it super simple. If lato is found use it; otherwise use the old defaults. So even if you never run the installer you should be OK. |
|
This is an obvious improvement - just gonna merge it We should make a beta 6 - this bug is real |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Rather than try and runtime load the Lato font assume it is installed and react accordingly if it is not. No longer bundle it with the dll and instead bundle it with the installer. Closes surge-synthesizer#678 : Font causes Hang on some Windows Closes surge-synthesizer#673 : De-Bold our Lato Former-commit-id: 2e86d037bca7a78e53d2ff204ab65391f4ebbd9c [formerly 0a19dab] Former-commit-id: 5ca736ed704cb2b4860644f167ff29ad53669a10 Former-commit-id: 126e499a3470bb74cf3d7a2cf6edb28cf6f3d30c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try and runtime load the Lato font assume it is installed
and react accordingly if it is not. No longer bundle it with the dll
and instead bundle it with the installer.
Closes #678 : Font causes Hang on some Windows
Closes #673 : De-Bold our Lato