Make typein for ct_float_toggle work #6815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes surge-synthesizer#6814 Also rename calculate_modulation_value_from_string() to set_modulation_value_from_string() to match set_value_from_string() API.
mx
reviewed
Jan 22, 2023
|
Oooh but it doesn’t set the modulation value it calculates it and an external client sets it so can we undo that name change? |
|
(It doesn’t set it because the parameter doesn’t know which modulator is querying the parameter) |
|
Sure I'll revert that, maybe shorten to calc instead of calculate. |
|
that will just break rack when i pull next. if we can leave the name the same that'd be super! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6814
Also rename calculate_modulation_value_from_string() to set_modulation_value_from_string() to match set_value_from_string() API.