Invalidate all params etc... on patch change #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A patch change can change the name or value of any param. So when it happens send the maximal updateHostDispolay (excluding latency). Trigger this with a new patchChanged atomic on the synth which we set to true at the end of the off-thread load. Results in bitwig showing all correct param changes on patch change in vst3 and presumably other compliant hosts would do same. Closes surge-synthesizer#6607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch change can change the name or value of any param. So when it happens send the maximal updateHostDispolay (excluding latency). Trigger this with a new patchChanged atomic on the synth which we set to true at the end of the off-thread load. Results in bitwig showing all correct param changes on patch change in vst3 and presumably other compliant hosts would do same.
Closes #6607