Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Chorus and Delay, Pingpong -> Ping-Pong #676

Closed
wants to merge 1 commit into from
Closed

Separate Chorus and Delay, Pingpong -> Ping-Pong #676

wants to merge 1 commit into from

Conversation

esaruoho
Copy link
Collaborator

@esaruoho esaruoho commented Feb 27, 2019 •
edited
Loading

  • Moves all Choruses from Delay/Chorus to Chorus-subfolder
  • Renames Delay/Chorus to Delay
  • Renames Pingpong FX to Ping-Pong

fixes #675

@esaruoho
Separate Chorus and Delay
0ea9dd1 
This moves all Choruses from Delay/Chorus to Chorus, and corrects Pingpong to Ping-Pong
@esaruoho esaruoho requested a review from baconpaul February 27, 2019 08:12
@esaruoho esaruoho mentioned this pull request Feb 27, 2019
Closed
@esaruoho
Copy link
Collaborator Author

not what's wanted since delay/chorus fx are specifically different from chorus fx, not the same parameters at all

@esaruoho esaruoho closed this Feb 27, 2019
@esaruoho esaruoho deleted the chorusdelay-fx-changes branch February 27, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baconpaul baconpaul Awaiting requested review from baconpaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FX section Delay/Chorus = Delay only
1 participant
@esaruoho