Fix WT-length-one clamp error #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions we allowed wavetables of length one but when doing so missed this clamp which resulted in hi < lo. that is UB (but defacto clamped to low) but that inversion triggers an assert on some configurations. So (1) add a debug assert to our limit range and (2) use a max of 0 on the upper bound. Closes surge-synthesizer#6702
mkruselj
pushed a commit
to mkruselj/surge
that referenced
this pull request
Nov 29, 2022
In recent versions we allowed wavetables of length one but when doing so missed this clamp which resulted in hi < lo. that is UB (but defacto clamped to low) but that inversion triggers an assert on some configurations. So (1) add a debug assert to our limit range and (2) use a max of 0 on the upper bound. Closes surge-synthesizer#6702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions we allowed wavetables of length one but when doing so missed this clamp which resulted in hi < lo. that is UB (but defacto clamped to low) but that inversion triggers an assert on some configurations.
So (1) add a debug assert to our limit range and (2) use a max of 0 on the upper bound.
Closes #6702