Don't hardcode timepos sample rate to 44100 in AU #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AU had a hard coded 44100. Rather than use that, cache the last sample rate we saw when reset and use it to advance timepos in the sample block. Related to surge-synthesizer#662.
|
Oh the code formatting here is a mess. #663 will have me clean that up in a separate commit. |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
) AU had a hard coded 44100. Rather than use that, cache the last sample rate we saw when reset and use it to advance timepos in the sample block. Related to surge-synthesizer#662. Former-commit-id: df958bfbd6f241548bdafd7f403c86ce6316267a [formerly 121ba9e] Former-commit-id: c56dc64c9d367cd76bde5d73368592b61462cf36 Former-commit-id: 8f5760dc2cf03911c9fc8fb37a8117b83e16751b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AU had a hard coded 44100. Rather than use that, cache the last sample
rate we saw when reset and use it to advance timepos in the sample block.
Related to #662.