Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Vocal Wavetables for Surge" by Layzer #602

Closed
wants to merge 1 commit into from

Conversation

esaruoho
Copy link
Collaborator

https://www.kvraudio.com/forum/viewtopic.php?p=7313640#p7313640

when asked about if he would allow it to be added to surge:

sure, no problem. i put it out there for everyone.
i just dont want people selling them.

@baconpaul
Copy link
Collaborator

“Xlz Voc” is not a great name for the parent directory for users - can we use a better name somehow?

@esaruoho
Copy link
Collaborator Author

@baconpaul agreed. i'll consult layzer

@baconpaul
Copy link
Collaborator

Cool. And maybe code up a 3rd party wt file also so we get a line like in patches. All to do to do

@esaruoho
Copy link
Collaborator Author

referenced at #603

@esaruoho
Copy link
Collaborator Author

@baconpaul while there's a to-do-to-do on that 3rd party wt file format / separator, could this be merged anyway? :)

@baconpaul
Copy link
Collaborator

I'd rather get to the separator. I promise I will.

@esaruoho
Copy link
Collaborator Author

@baconpaul ok cool! :)

@baconpaul
Copy link
Collaborator

OK @esaruoho I'm going to close this PR and pull your commit onto my branch baconpaul/third-party-wavetables-603 where I implement the separator. I'll sweep these wavetables in along with the separator code. (I'll leave you in the commit log don't worry!)

This also means I can delete this branch hanging around in the surge repo, so I'll do that too.

@baconpaul baconpaul closed this Feb 28, 2019
@baconpaul baconpaul deleted the xlz_voc_wavetables branch February 28, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants