UTF8 for Wavetables; Noisier Mis-installation; Win Categories #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UTF8 filename conversion is required on windows for vstgui so factor the UTF8 string conversion into a function and adjust the callpoints. Those callpoints intersect with places where we load patches and wavetables, so at the same time, make the system report user errors if wavetables or factory patches are non-loadable In the course of testing this, I also realized that nested directories didn't work properly on windows due to path separator being "\" rather than "/", which this commit also addresses. Closes surge-synthesizer#584 UTF8 for wavetables Closes surge-synthesizer#543 Alert user to mis-installation pathsetp
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
…synthesizer#601) UTF8 filename conversion is required on windows for vstgui so factor the UTF8 string conversion into a function and adjust the callpoints. Those callpoints intersect with places where we load patches and wavetables, so at the same time, make the system report user errors if wavetables or factory patches are non-loadable In the course of testing this, I also realized that nested directories didn't work properly on windows due to path separator being "\" rather than "/", which this commit also addresses. Closes surge-synthesizer#584 UTF8 for wavetables Closes surge-synthesizer#543 Alert user to mis-installation Former-commit-id: fa14f35e66637b22717f0fd0d761f56a1b29b27b [formerly 778fea1] Former-commit-id: 14394184250701dcdebe9ab4027353b91f093fc9 Former-commit-id: 4bf6ca7017713438e971b75deeabe996c1319fae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF8 filename conversion is required on windows for vstgui so factor
the UTF8 string conversion into a function and adjust the callpoints.
Those callpoints intersect with places where we load patches and
wavetables, so at the same time, make the system report user errors
if wavetables or factory patches are non-loadable
In the course of testing this, I also realized that nested directories
didn't work properly on windows due to path separator being "" rather
than "/", which this commit also addresses.
Closes #584 UTF8 for wavetables
Closes #543 Alert user to mis-installation