Two Zoom Changes (Resolution and Extrema) #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is all pretty mechanical. @jsakkine or @kzantow if you want to peek appreciate it. I'll probably sweep tomorrow evening eastern unless I hear otherwise. Thanks! |
esaruoho
changed the title
|
tested with vst2/renoise and au/logic. 125% looks great. renoise handles max res nice. but logic OTOH: i.e., i can't access Menu now because Surge is way larger than it should be |
|
Ahh that's because the window decoration trim is too aggressive. I need to turn it back. Sigh. |
baconpaul
force-pushed
the
use-125asset-540
branch
from
4ca94f8 to
a72333d
Compare
|
Pushed a change to max it out at 90% on mac as well as win. |
Activate the 125x assets by making them callable in CScalableBitmap, activating them in win script, and re-rendering the win resource files. Also add a function "Zoom to Largest" which takes zoom to exactly the point below where we would warn that you can't zoom any larger for your screen, and "Zoom to Smallest", so that @sense-amr can do crazy things with bitwig and Orca. Moreover on smaller monitors, 95% zoom in logic pro is too large and eats the menu button due to decoration, so in this change we move to 90% of screen as max for all oses. Closes 540: Activate 125% assets Closes 590: Zoom to Biggest Menu
baconpaul
force-pushed
the
use-125asset-540
branch
from
a72333d to
5d12d0b
Compare
baconpaul
changed the title
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Activate the 125x assets by making them callable in CScalableBitmap, activating them in win script, and re-rendering the win resource files. Also add a function "Zoom to Largest" which takes zoom to exactly the point below where we would warn that you can't zoom any larger for your screen, and "Zoom to Smallest", so that @sense-amr can do crazy things with bitwig and Orca. Moreover on smaller monitors, 95% zoom in logic pro is too large and eats the menu button due to decoration, so in this change we move to 90% of screen as max for all oses. Closes surge-synthesizer#540: Activate 125% assets Closes surge-synthesizer#590: Zoom to Biggest Menu Former-commit-id: ffda50b51e609979f03ac4c306d66aad336f91a2 [formerly 571a3d3] Former-commit-id: 06ca64ef12ff34c4ac724585d33cb916e06ae7a3 Former-commit-id: 3f1c1540755c77231baf63d749da883cfaa51d56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate the 125x assets by making them callable in CScalableBitmap,
activating them in win script, and re-rendering the win resource files.
Also add a function "Zoom to Largest" which takes zoom to exactly the
point below where we would warn that you can't zoom any larger for your
screen.
Closes #540: Activate 125% assets
Closes #590: Zoom to Biggest Menu