Menu Colors in Skins with a default Dark/Light also

[baconpaul]

New feature in skins menu - menus always dark/light/follow skin
Colors in skin which map to current dark menus by default
Light mode works and sticks

Closes #5861

[mkruselj]

I think I would've preferred per skin colors for the menus rather than a global option, but easy to modify down the road.

[baconpaul]

I think I would've preferred per skin colors for the menus rather than a global option, but easy to modify down the road.

since that exact feature is in the code, i'm not sure i understand your comment.

[mkruselj]

Right I meant just not necessary to have a userdefaults thingie, instead hardcode them to each skin so that it always matches.

[baconpaul]

Yeah I thought about using the os light dark default also. Most apps I have used don’t override the menus with settings so I wanted an option to skip out of that and just have light. But the default is to use whatever is in the skin

[baconpaul]

If we had user skin color overrides we could of course get rid of the sticky option

[mkruselj]

Is there any way we can get OS light/dark setting then follow it, then just have a single menu option to toggle using menu skin colors from the skin?

[baconpaul]

I know how to do that on Mac but not on win yet but sure it’s just an api

[mkruselj]

Hmmm apparently not, we gotta read registry.

[baconpaul]

Ha it's funny. I just committed to sstplugin infra saying 'it will all work we just gotta read the registry'

the registry is the api. that's one of the worst things about windows, but it's also true!