fix #544 Inactive buttons [Linux] #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. But this or has more commits than just the fix. Maybe best to close it and submit from a branch with just your change and not the other 4 commits? |
|
@baconpaul loox like he fixed it. |
|
Yup! Don’t suppose you can test on Mac that mute and solo still work with this branch could you? If not I can do so later tonight or tomorrow |
|
Confirms this works on mac. |
|
And confirms it works on windows. Will update commit comment and merge. |
baconpaul
pushed a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
…#588) Solo, Mute, and other CSwitchControl buttons were inactive on Linux because CScalableBitmap returns size 0,0 for all bitmaps on Linux. This diff doesn't solve that problem but accommodates it by making CSwitchControl work like the other switch controls; using a constructor specified size (in this case the size of the view rectangle) to determine how much to translate the switching image. This makes solo, mute, and others work on Linux. Closes surge-synthesizer#544 by making those buttons inactive. Former-commit-id: a2a858c26719c32a55904661ee9b7ca12eefdc66 [formerly 40e18d1] Former-commit-id: 40ef5151482e5843a0503ce5d2fb87d0a0d19eaa Former-commit-id: df1b0bc9beb018eb159d39e1000c085d465c2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.