Remove unused getSelfLocation #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the very early days of the mac port, we thought we needed getSelfLocation in SurgeStorage, but then realized we didn't so took out that code path. But we didn't take out the implementation. Do so.
kzantow
approved these changes
Feb 11, 2019
|
Thanks for the look! I'll merge it in. |
|
Oh and for the future, VSTGUI::getBundleRef() does basically the same thing on macOS for us. #include "vstgui/lib/platform/mac/macglobals.h" in case you want it. |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
At the very early days of the mac port, we thought we needed getSelfLocation in SurgeStorage, but then realized we didn't so took out that code path. But we didn't take out the implementation. Do so. Former-commit-id: 937f94bea8869e9a9cf3a9db164b774119b17a17 [formerly b273f9e] Former-commit-id: 4af809fe83345d3aca64f4929db75ae9a1c0eada Former-commit-id: 83433882863ac2fdd174eb1dd2a95d3bfd96f3bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the very early days of the mac port, we thought we needed
getSelfLocation in SurgeStorage, but then realized we didn't
so took out that code path. But we didn't take out the implementation.
Do so.