Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about JUCE and Qt to the documentation #564

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Add a note about JUCE and Qt to the documentation #564

merged 1 commit into from
Feb 10, 2019

Conversation

jarkkojs
Copy link
Collaborator

Summarizes the discussion in #486.

Closes: #486

Summarizes the discussion in #486.

Closes: #486
@jarkkojs
Copy link
Collaborator Author

Seems that Github recognizes that Closes tag, which I did not know before (shows a tooltip).

@baconpaul
Copy link
Collaborator

Yeah looks good.

Redoing zoom without cocoa in AU will be a pain. But otherwise it looks like a fine summary of our discussions.

Wonder if dpf may also be an option?

But I'm happy with your doc!

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 10, 2019

@baconpaul, maybe so but we still would reduce the amount of specialized code. I don't know what dpf is but I know that Qt is the best application framework available for C++. And the subsection does not dictate to use Qt. It is just the current analysis of it. It is mentioned as a viable option.

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 10, 2019

@baconpaul, good to here. Lets not create an architecture specification. Lets instead evolve one over time. Otherwise we end up with a document that is both useless and unreadable.

@jarkkojs
Copy link
Collaborator Author

Can we close this now?

@baconpaul
Copy link
Collaborator

Yeah sure! Fine with me.

@jarkkojs jarkkojs merged commit 63d415f into surge-synthesizer:master Feb 10, 2019
@falkTX
Copy link
Contributor

falkTX commented Feb 10, 2019

Huh, Qt for GUIs is a really terrible idea.
It is a huge codebase which we would have to build statically for the plugin, just for a few OS independent things...

@jarkkojs
Copy link
Collaborator Author

@falkTX, there is no roadmap ATM to use Qt. And there is no requirement to link Qt statically even if we end up using it.

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 10, 2019

Actually Windows would be a problem without static linkage. However, static linking is not by itself is not any kind of problem.

  • It does not really matter how fat the resulting binary is. Kernel mm will fault only the pages that it actually uses in Windows, macOS and Linux.
  • Huge codebase is not a problem as it is a mature toolkit. We don't care all that much about Qt's source code.
  • We are compatible in terms of licensing for static linkage. Qt is licensed with LGPL3 (among some other licensing options).

Only thing that it would affect is that the Qt SDK (which is free) would be required to compile Surge. Not a big deal.

@jarkkojs jarkkojs deleted the a-note-about-juce-and-qt branch February 10, 2019 18:25
baconpaul pushed a commit to baconpaul/surge that referenced this pull request Jul 10, 2019
…uce-and-qt

Add a note about JUCE and Qt to the documentation

Former-commit-id: 11b8aeeed3f9c037f20e0819315fb5d337d6ebfa [formerly 63d415f]
Former-commit-id: d3c9a4614fdb5095ed34f7a32708a5049cade020
Former-commit-id: 53ae74e3e8ac2a266173cfc3a5d5ef312a392ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants