Handle NAN and INF from Formula #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaN and Inf from formula would rip through the engine and blow through various checks and so on. So inside formula do an explicit std::isfinite and set a flag if they return these. Also add a unit test of the behavior. Closes surge-synthesizer#5566
baconpaul
force-pushed
the
handle-formnan-5566
branch
from
58f2463 to
5757c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaN and Inf from formula would rip through the engine and
blow through various checks and so on. So inside formula
do an explicit std::isfinite and set a flag if they return
these.
Closes #5566