Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New features for build-linux.sh #550

Merged
merged 1 commit into from
Feb 9, 2019
Merged

New features for build-linux.sh #550

merged 1 commit into from
Feb 9, 2019

Conversation

jarkkojs
Copy link
Collaborator

@jarkkojs jarkkojs commented Feb 9, 2019 •
edited
Loading

No description provided.

@baconpaul
Copy link
Collaborator

Heya

Happy to merge this but it won't fix 542; we also need to modify the c++ in surge storage to read from usr
Loca! Share.
can we combine that modification with this script in a single PR?

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 9, 2019

Yes. I can do that. I'm also proposing that instead of two commands you would have --local for local install as I've integrated getopt already.

@baconpaul
Copy link
Collaborator

Sounds good to me!

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 9, 2019

@baconpaul, can you take this first, fixes-tag has been removed. Decided to take some time to do all requested features to script, like selecting a specific target and the debug build. Now have take a break and do the code change later.

@jarkkojs jarkkojs changed the title Add global install command to build-linux.sh New feature for build-linux.sg Feb 9, 2019
@baconpaul
Copy link
Collaborator

Yeah no problem. Let me just read it. We can do the code change in a separate PR.

Looking now.

@baconpaul
Copy link
Collaborator

Looks great to me.
I'm about to take off. Why don't you just merge this once the automatic builds report success?
Thanks!

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 9, 2019

Another push (just updated the help text, that's all).

@jarkkojs jarkkojs changed the title New feature for build-linux.sg New features for build-linux.sh Feb 9, 2019
@jarkkojs
New build-linux.sh features
af42d4e 
* --project=[vst2|vst3|
* --debug do debug build
* --local for local install
@jarkkojs jarkkojs merged commit 95996a3 into surge-synthesizer:master Feb 9, 2019
baconpaul pushed a commit to baconpaul/surge that referenced this pull request Jul 10, 2019
@jarkkojs
Merge pull request surge-synthesizer#550 from jsakkine/master
4321dec 
New features for build-linux.sh

Former-commit-id: ec2efae5437c67e24e727afed38a6ae45d111633 [formerly 95996a3]
Former-commit-id: 50da3b03efd410faa192562ef8817372a7de60a3
Former-commit-id: c906d7e85d69fa7a849d2721b6aefba93bb18077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarkkojs @baconpaul