Change create cycle for member-owned components #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Components which were owned by the skin-collective correctly reused their instances but ones which were member assigned did the wrong thing. Correct this, which also stops over-creation of the patch selector, effect chooser, and a few more. This fixes several things including 1. Closes surge-synthesizer#5365 2. Fixes an accesibility problem where the patch selector changes instance 3. Generaly churns less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components which were owned by the skin-collective correctly reused
their instances but ones which were member assigned did the wrong
thing. Correct this, which also stops over-creation of the
patch selector, effect chooser, and a few more.
This fixes several things including