Memory Reuse for allocating oscillators: String #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconpaul
force-pushed
the
memory-pool-string-4840
branch
from
b6b2eea to
5931cbd
Compare
baconpaul
changed the title
selenologist
approved these changes
Oct 17, 2021
baconpaul
changed the title
This commit gives an API which allows us to reuse rather than reallocate the memory buffers that objects need at play time. Right now it only deals with the string oscillator and still does 'extra' allocation on the audio thread, but has a reasonable pre-allocate and re-use strategy. In the future the overflow allocs could be off thread but for now it's a simple save and reuse approach. Thanks to Luna for a review, and also glad I added that test! Closes surge-synthesizer#4840
baconpaul
force-pushed
the
memory-pool-string-4840
branch
from
f495d5b to
36334e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives an API which allows us to reuse rather
than reallocate the memory buffers that objects need
at play time. Right now it only deals with the string
oscillator and still does 'extra' allocation on the audio
thread, but has a reasonable pre-allocate and re-use
strategy. In the future the overflow allocs could be
off thread but for now it's a simple save and reuse
approach.
Closes #4840