Greatly shrink the Synthesizer::ID code #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthesizer::ID was a bunch of plubming to allow indices, ids, and param ids to all co-exist, but iwth JUCE we really only need param ids. I could have removed this class altogether but decided to keep the indirection until a rainy day, so the ID is now a simple wrapper on an int which is the param index. Closes surge-synthesizer#4866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesizer::ID was a bunch of plubming to allow indices,
ids, and param ids to all co-exist, but iwth JUCE we really
only need param ids.
I could have removed this class altogether but decided to keep
the indirection until a rainy day, so the ID is now a simple wrapper
on an int which is the param index.
Closes #4866