Change a few patch db things #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't initialize the DB on startup; rather init it when you first open the patch browser 2. End my 'throw in destructor' bad habit since that worked horribly. Catch everything properly etc... This closes surge-synthesizer#4822 but there's still lots to do in surge-synthesizer#2359 including a nasty locked handler fail when you start two surges against a fresh db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you first open the patch browser
horribly. Catch everything properly etc...
This closes #4822 but there's still lots to do in #2359 including
a nasty locked handler fail when you start two surges against a fresh
db