Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of RPM package builder. #4525

Merged
merged 2 commits into from
May 8, 2021

Conversation

gnac
Copy link
Contributor

@gnac gnac commented May 8, 2021

Added a script (make_rpm.sh) to support the ability to build an RPM on rpmbuild enabled systems.
Added a custom build rule (surge-xt-rpm) to CMakeLists to invoke the make_rpm script.
Added a build step to make_deb.sh to create a tarball of the same folder hierarchy used to build the deb package.
Modified call to find shared libraries to use -exec instead of piping to xargs as xargs was barfing on spaces. Alternatively, we could have passed -0 to xargs.
Added some additional build instructions to Readme.

Added a script (make_rpm.sh) to support the ability to build an RPM on rpmbuild enabled systems.
Added a custom build rule (surge-xt-rpm) to CMakeLists to invoke the make_rpm script.
Added a build step to make_deb.sh to create a tarball of the same folder hierarchy used to build the deb package.
Modified call to find shared libraries to use -exec instead of piping to xargs as xargs was barfing on spaces. Alternatively, we could >
Added some additional build instructions to Readme.
@baconpaul
Copy link
Collaborator

All looks great.
What do I need to apt-get on ubuntu to get rpm build tools in the pipeline?
if CI all runs (which it should) I'll merge this and mod the release pipeline once it is through one pass without the build. sound good?

@baconpaul baconpaul merged commit 90e93f2 into surge-synthesizer:main May 8, 2021
@gnac
Copy link
Contributor Author

gnac commented May 8, 2021

What do I need to apt-get on ubuntu to get rpm build tools in the pipeline?
"apt-get install rpm"
This includes the necessary rpmbuild command.

@baconpaul
Copy link
Collaborator

yup cool thanks!

@gnac gnac deleted the rpm-package-4524 branch May 8, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants