Fix two menu reset problems #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably codereview required, but tester's side is lgtm |
|
@jsakkine if you are online could you just eyeball the code. I see one wonky () spacing but other than that I think it is OK. (I'll fix that wonky paren and re-push but you can look still). |
As reported in surge-synthesizer#268, the menu reset i put was too heavy handed. Make it so it cant reset "Timbre and the like". As reported in surge-synthesizer#261, if you are in auto-name mode and remove your first mapping you shoudl change the name. Comment this since the logic required more than 10 seconds thought.
baconpaul
force-pushed
the
menus-261-268
branch
from
c66b3f7 to
f444773
Compare
|
Looking into this. Hold on. |
|
Simple question: what is EID? |
|
Eid is the counter menus use as they build in current code. Element id perhaps? I just kept the name in the tracking variable |
|
Already merged, but looked good to me (except spacing and maybe static_cast<> instead of C style cast). |
|
I thought I fixed all the spacing! Thanks for looking tho! Yeah static cast in new code is better. I was sloppy copying the old cast here. |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Fix two menu reset problems. Closes surge-synthesizer#261. Closes surge-synthesizer#268. Former-commit-id: 68ac24f7583c18164982ff7357904e5d136948ff [formerly 3aac6c2] Former-commit-id: 0816d9c67c8a90098152c173c8b772009d4f34b0 Former-commit-id: 23290d2907294bec6188493b4e2f5fcd32f8814c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #268, the menu reset i put was too heavy handed.
Make it so it cant reset "Timbre and the like".
As reported in #261, if you are in auto-name mode and remove
your first mapping you shoudl change the name. Comment this since
the logic required more than 10 seconds thought.