Remove CriticalSection, replace with std::mutex #2765
Conversation
Didn't seem to be used recursively. If it is after all, that's a bug that needs fixing. If it can't be fixed right away, there's always std::recursive_mutex to restore the old behavior.
|
Oooh would have been good to chat since there are recursive uses and I’ve never trapped them. #1249 Gives you one example What happens now if we do recourse? Deadlock? |
| @@ -51,6 +51,10 @@ | |||
| #include <stack> | |||
| #include <unordered_map> | |||
|
|
|||
| #if WINDOWS | |||
| #include <windows.h> | |||
| #endif | |||
There was a problem hiding this comment.
This is for the definitions of SYSTEMTIME/GetSystemTime. Before, windows.h was included implicitly via SurgeStorage.h→CriticalSection.h.
There was a problem hiding this comment.
Thanks!
We should move that to std::chrono one day
There was a problem hiding this comment.
we actually didn't need the time at all so just cleaned it up and pushed
Yes, which is hopefully easy to debug. Recursive mutexes are a hack and especially bad in audio applications. It seems that the current known recursive use it not intentional though. I'll look into that. |
Didn't seem to be used recursively. If it is after all, that's a bug
that needs fixing. If it can't be fixed right away, there's always
std::recursive_mutex to restore the old behavior.