Throw SurgeError when configuration.xml is not found #251
Conversation
|
After this fix Renoise at least fails cleanly and does not eat all memory. This commit really helps to continue debugging with Renoise because you don't have to always wait that it eats all your memory and crashes (takes a few minutes). I really hope it gets pulled. |
|
Much much nicer end result. |
|
Perhaps SurgeError should just take the message in its constructor because we are only going to just display a message anyway? I.e. I could make it even more dummier. The class is mainly for situations that will anyway end up the plugin being closed so I think that would be perfectly adequate. |
|
I think we probably want a correct error feedback library still since there are other places where we pop a message box and expect to continue operating. My guess is we end up removing this particular throw when we sort everything out. But I agree it is a good interim step on linux so I would be happy to sweep. Have you built it mac and windows? I don't have time to do that right now. Looks like it should build but there is some stuff which is not in an ifdef. |
Add a custom exception class SurgeError that is used to fail SurgeStorage constructor when configuration.xml is not found. This is needed to avoid null pointer dereferences because the code after that assumes that the loading succeeded. Scope this only for Linux now up until we have a functionality to display an error dialog for all platforms. This commit prevents Renoise from exhausting resources and finally crashing in the situation where configuration.xml is not found. Signed-off-by: Jarkko Sakkinen <[email protected]>
|
builds and runs mac; totally standard c++; sweeping with the caveat that I bet this will change again in some regard |
|
@baconpaul, yeah that is why I did not even try to over-engineer the exception class. Something dead simple we can refine as we go :) |
Throw SurgeError when configuration.xml is not found Former-commit-id: 86a7653854921cf4f76fd9e69dfe96622810070f [formerly 4e63226] Former-commit-id: c948466df3e6f257d80098ff4fa6030454b6e2df Former-commit-id: 782fb54c33a0c83b8b47d0173cb9219646c3d096
Add a custom exception class SurgeError that is used to fail SurgeStorage constructor when configuration.xml is not found.
Not a perfect fix for #250 but exception is better than a crash for the VST host.