Deal with a dissapearing cursor on windows #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was calling spawn_miniedit_text modally inside an already modal loop so the modal loops unwound improperly in some cases not restoring cursor. This meant controller name on windows would eat the cursor Fix it by haing the menu defer the call in a VSTGUI::Call::later did a quick review and the other spots with miniedit are already deferred it seems or are called from different parts of the event loop Closes surge-synthesizer#1465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was calling spawn_miniedit_text modally inside an already modal
loop so the modal loops unwound improperly in some cases not restoring
cursor. This meant controller name on windows would eat the cursor
Fix it by haing the menu defer the call in a VSTGUI::Call::later
did a quick review and the other spots with miniedit are already
deferred it seems or are called from different parts of the event
loop
Closes #1465