Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pedal Edge Case Bugs #1582

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Conversation

baconpaul
Copy link
Collaborator

  1. Midi channel 3 and 4 picked channel mask incorrectly.
    Make it mode aware and do the right thing
  2. Multiple presses of a key on and off while the systain
    pedal was held mis-set-up the internal voice structures.

Closes #1554

1. Midi channel 3 and 4 picked channel mask incorrectly.
   Make it mode aware and do the right thing
2. Multiple presses of a key on and off while the systain
   pedal was held mis-set-up the internal voice structures.

Closes surge-synthesizer#1554
@baconpaul baconpaul merged commit a0a9752 into surge-synthesizer:master Feb 15, 2020
@baconpaul baconpaul deleted the pedal-1554 branch March 12, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notes "stuck" when using sustain pedal (MIDI CH 3 & 4) Other midi channels have problem as well...
1 participant