Support KBM Files #1462
Merged
Support KBM Files #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses surge-synthesizer#1041 This larger diff supports KBM files inside the surge engine but doesn't include the workflow to load them in the UI or display them at tuning time yet. Rather it sets up the ability to parse KBM files and push them onto the storage and note architecture and uses the Unit Test frameowrk to show that the synth is properly retuned and remapped. - Unit tests confirm we parse valid KBM files properly - Add SurgeStorage hooks for a current mapping - Confirm tuning and mapping for full-keyboard mappings works - Allow users to pick a KBM file Still work to do on persisting and showing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1041
This larger diff supports KBM files inside the surge engine
but doesn't include the workflow to load them in the UI or display
them at tuning time yet. Rather it sets up the ability to parse
KBM files and push them onto the storage and note architecture
and uses the Unit Test frameowrk to show that the synth is properly
retuned and remapped.
Still work to do on persisting and showing.