Fix an Init Delay Timing Condition #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Init on Delay with temposync could happen before the global tempo was set when you unstreamed in a DAW. As a result the lag for the time would catch up on the first and only first play leading to glitches. To fix it, detect if setvars(true) (the init condition) is called when temposync hasn't been set yet and defer the initialization if so. The frequency shifter would have the same bug so fix that also. Closes surge-synthesizer#1444.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init on Delay with temposync could happen before the global
tempo was set when you unstreamed in a DAW. As a result the
lag for the time would catch up on the first and only first
play leading to glitches. To fix it, detect if setvars(true)
(the init condition) is called when temposync hasn't been set
yet and defer the initialization if so.
The frequency shifter would have the same bug so fix that also.
Closes #1444.