In TANH mode use TANH #1244
Merged
In TANH mode use TANH #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had left an if in from an early version which had 'none' in the mix of parameters; that de-facto meant that tanh mode (the default) had no waveshaper. Remove the specious if and restore the default behavior to the 1.6.2.1 behavior Addresess surge-synthesizer#1213
baconpaul
added a commit
to baconpaul/surge-fx
that referenced
this pull request
Oct 11, 2019
MOve Surge pointer to collect the surge-synthesizer/surge#1244 fix. Closes #28
baconpaul
added a commit
to surge-synthesizer/surge-fx
that referenced
this pull request
Oct 11, 2019
MOve Surge pointer to collect the surge-synthesizer/surge#1244 fix. Closes #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had left an if in from an early version which had 'none' in
the mix of parameters; that de-facto meant that tanh mode
(the default) had no waveshaper. Remove the specious if
and restore the default behavior to the 1.6.2.1 behavior
Addresess #1213