Exit with '_exit' when zenity is missing #1204
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkTX
approved these changes
Sep 21, 2019
|
Oh this one avoids the crash but there's one more change we need. This will default to "cancel" which is not what we want when zenity isn't there. |
Per comment from @falkTX on surge-synthesizer#1199 this will stop our missing-zenity-core
baconpaul
force-pushed
the
zenity-exit-1199
branch
from
2e57826 to
f7225b0
Compare
|
Alright just did a force push of the 'fail open' for OK/Cancel. @falkTX would you mind another peek? I think this is the right solution. Thank you ver much! |
|
Actually i don't need to burn your time look at this @falkTX - thanks for the origin comment but I'm sure my additional "if" statement is fine now I look at it. I'll merge and then ask original user to test the nightly. Really appreciate that _exit tip. I would have never found it and had a rube goldberg solution with making sure zenity was in path starting to get ready for me to show you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment from @falkTX on #1199 this will stop our missing-zenity-core