Activate control values from patch stream #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in surge-synthesizer#915, for some reason the patch unstream doesn't restore the value of the 8 controls whereas daw unstream does. This is a conscious choice by the code for no reason any of us can see, and is counterintuitive, so change it.
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Aug 13, 2019
The ModButton wheel on windows was too slow; speed it up. While I'm in there support shift-wheel also just for completeness. Closes surge-synthesizer#1008
baconpaul
added a commit
that referenced
this pull request
Aug 13, 2019
The ModButton wheel on windows was too slow; speed it up. While I'm in there support shift-wheel also just for completeness. Closes #1008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #915, for some reason the patch unstream doesn't
restore the value of the 8 controls whereas daw unstream does. This
is a conscious choice by the code for no reason any of us can see,
and is counterintuitive, so change it.