Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom fails VST2 Linux Reaper #937

Closed
fourstepper opened this issue Jul 8, 2019 · 6 comments
Closed

Zoom fails VST2 Linux Reaper #937

fourstepper opened this issue Jul 8, 2019 · 6 comments
Labels
Host Specific Issues related to specific host(s) or host features Linux Issues which only occur on Linux
Milestone

Comments

@fourstepper
Copy link

Describe the bug
The GUI doesn't render completely after plugin scaling (zooming) capabilities are initiated

Please let us know your surge version
This information is all in the menu/about screen

  • Surge Version: 1.6.1
  • Plugin type: VST2 under Linux 64bit, kernel version 5.1.15-1

To Reproduce
Steps to reproduce the behavior:

  1. Open Surge as a VST2 in Reaper
  2. Click on Menu > Zoom 150%

Expected behavior
A clearly and fully loaded scaled GUI

Screenshots
https://imgur.com/a/7fkbTco

Desktop (please complete the following information):

  • OS: Linux Manjaro
  • Host: Reaper
  • Version: Reaper 5.79 (latest)

Additional context
Add any other context about the problem here.

@baconpaul baconpaul added Host Specific Issues related to specific host(s) or host features Linux Issues which only occur on Linux labels Jul 8, 2019
@baconpaul baconpaul changed the title Incomplete GUI rendering when zooming into the plugin Zoom fails VST2 Renoise Linux Jul 8, 2019
@baconpaul
Copy link
Collaborator

Link to #938. Thanks for the report!

@baconpaul baconpaul changed the title Zoom fails VST2 Renoise Linux Zoom fails VST2 Linux Reaper Jul 8, 2019
@baconpaul baconpaul added this to the 1.6.2 milestone Jul 8, 2019
@baconpaul
Copy link
Collaborator

@fourstepper this is "really hard" to fix with the vst2 but in the upcoming 1.6.2 release, I have the VST3 working with Reaper on Linux. Presuming I get all the bugs sorted out in VST3 linux reaper (there's only one left) and the vst3 builds from source and ships in the deb, any reason that wouldn't work for you?

(The reason it is really hard to fix is that there is no VST2 zoom API and on X, the window size / parent API is way trickier than in other places; VST3 has a zoom API and zoom in reaper linux vst3 works fine).

@fourstepper
Copy link
Author

Hello @baconpaul, thank you for reviewing my issue and for the upcoming fix. The solution you have presented totally seems good to me, thank you.

Best regards and good luck!

@baconpaul
Copy link
Collaborator

OK great. I will update this issue when the VST3 is testable in the nightlies and working in reaper linux fully for me. (Right now it works and zooms fine for us, but has a crash on exit occasionally I need to resolve; also it is not in the deb distribution).

@fourstepper
Copy link
Author

Wicked. Thanks a lot!

baconpaul added a commit that referenced this issue Aug 20, 2019
The LInux VST3 now cleanly shuts down its runloop, meaning
it works completely in reaper linux. I have included it in the
deb file for installation as a result.

Addresses #514
Addresses #937
@baconpaul
Copy link
Collaborator

OK cool the crash on exit fix was easy as was the .deb file change. If you build from source at current master or grab the nightly deb from the website and install, you should get a /usr/lib/vst3/Surge.vst3 which will load and zoom and generally work great in linux reaper.

Please feel free to reopen this issue or add a comment here if not; or confirm if it does if you want.

THanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Host Specific Issues related to specific host(s) or host features Linux Issues which only occur on Linux
Projects
None yet
Development

No branches or pull requests

2 participants