Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom state of Surge VST3 gets lost after reopen #912

Closed
mireiner opened this issue Jun 15, 2019 · 5 comments
Closed

Zoom state of Surge VST3 gets lost after reopen #912

mireiner opened this issue Jun 15, 2019 · 5 comments
Milestone
1.6.2

Comments

@mireiner
Copy link

mireiner commented Jun 15, 2019 •
edited
Loading

Describe the bug
GUI zoom states higher than 100% get lost after reopen Surge VST3.
Surge VST2 works fine (does remember zoom state after reopen)!

To Reproduce

  1. In Surge VST3 go to Menu/Zoom/Zoom to 150%
  2. Close Surge GUI
  3. Reopen Surge GUI
  4. Now Surge GUI is set back to zoom 100%

Expected behavior
After Surge VST3 is reopened it should remember its zoom state (for example 150%)

Desktop (please complete the following information):

  • OS: Windows 10 Professional 64 Bit Version 1803
  • Host: Presonus Studio One 4 Professional v4.5.1 64 bit
  • Surge VST3 Version: 1.6.1.1 VST3 64 bit
  • Surge-NIGHTLY-2019-06-15-546f9ea VST3 64 bit
@baconpaul
Copy link
Collaborator

Thanks for the accurate report and sorry for the bug. This behavior must have reverted when we fixed the opening “zoom dance” in the betas.

I’m taking a few week break from surge starting mid week - if this is easy to fix I will try and get it in a nightly but if not I can definitely fix it this summer

@baconpaul baconpaul added this to the 1.6.2 milestone Jun 16, 2019
@baconpaul
Copy link
Collaborator

Just FYI: This also occurs Bitwig / Mac so it is definitely a VST3 wide problem. Just adding this note in case I don't get it this evening!

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 16, 2019
@baconpaul
Remember zoom inside a session VST3
011fc4b 
With the change in startup path for the 'no-dance' default
size, the memory of last zoom feature of VST3 got dropped.
This restores it in a more sensible point.

Addresses surge-synthesizer#912
@baconpaul baconpaul mentioned this issue Jun 16, 2019
Merged
baconpaul added a commit that referenced this issue Jun 16, 2019
@baconpaul
Remember zoom inside a session VST3 (#913)
a0564ae 
With the change in startup path for the 'no-dance' default
size, the memory of last zoom feature of VST3 got dropped.
This restores it in a more sensible point.

Addresses #912
@baconpaul
Copy link
Collaborator

Yup this feature got lost when I did the zoom-dance-fix

Anyway I have just swept a correction. If you want, grab a nightly and you will have 1.6.1.1 plus this fix. We will do a 1.6.2 later this summer with this fix in place. Thank you for the bug report.

If you could confirm the nightly fixes it for you I would appreciate it. If it does please add a comment and close the issue.

Thank you!

@mireiner
Copy link
Author

mireiner commented Jun 16, 2019 •
edited
Loading

Hi Paul,
the new nightly build "Surge-NIGHTLY-2019-06-16-a0564ae-Setup.exe" for Windows 64bit fixed the problem (VST3 didn't lose the zoom state on reopen anymore).
But I found another problem. If the actual project inside the DAW is closed and reopened then Surge still loses its zoom state (open with zoom 100%). And this does happen with Surge VST2 and VST3 64 bit v1.6.1.1 and latest 2019-06-16 nightly versions on Windows 10 with Presonus Studio One v4.5.1 64 bit.

@baconpaul
Copy link
Collaborator

Yeah that’s always been the case but I can fix it now we shipped 16. I didn’t change the patch format at all until this point which is required for inter session. I’ll open a separate issue and close this one to track. Thanks!!!

This was referenced Jun 16, 2019
Closed
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
Remember zoom inside a session VST3 (surge-synthesizer#913)
ce97c93 
With the change in startup path for the 'no-dance' default
size, the memory of last zoom feature of VST3 got dropped.
This restores it in a more sensible point.

Addresses surge-synthesizer#912

Former-commit-id: aaf3701abd1b0bc0b81b82c42b08d98f07d91631 [formerly a0564ae]
Former-commit-id: bd268d80ede835b6102503c6a22a6abf8c1d7feb
Former-commit-id: f4f7ec1a1a40499f68e68be6ee0036ba18e2b47c
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.2
Development

No branches or pull requests
2 participants
@baconpaul @mireiner