Envelope restart point in monophonic play modes

[baconpaul]

As first reported at https://www.kvraudio.com/forum/viewtopic.php?p=7368001#p7368001

In mono modes the envelopes (Amp, Filter and all the LFOs) should have a 'legato' mode which means when they re-trigger rather than retrigger from 0 they re-trigger from current envelope level.

This image explains it clearly

Open questions are

1: Where to put the control in the UI (In the LFO we could put it under bipolar for instance)
2: How to code it up (but should be pretty easy since in the mono modes you are on the same voice so you have all the data structures)

[mkruselj]

Just as a sidenote, I wouldn't call it "legato" mode, I'd call it Reset mode, and then with options "Zero" and "Analog" (or "Current", but that might sound a bit confusing/ambiguous). Or, maybe best, should just be a single button called "Reset From Zero", which would be enabled by default (to preserve existing behavior).

Also it should work in polyphonic mode as well, whenever an already sounding voice is reached. Say you have 8 voices polyphony, 8 sounding voices in their release stage and you play a new note, it should take whatever the envelope level(s) were for that voice and go from there.

[baconpaul]

The poly mode trick will be hard; poly mode creates new voices and reaps old ones so it the a voice gets re-used it does not have the info about the prior voice playing in that slot. (Poly mode is also not a hard wall in surge remember; you can get to 10 voices in 8 voice poly mode in some situations)

Agree on your rejection of legato mode as name.

[mkruselj]

@baconpaul What do you think how complicated would this be to add? I was thinking adding this mode on RMB context for Play Mode parameter...

Code hints requested! :)

[VincyZed]

+1, that'd be sweet!

[baconpaul]

So the way I would do this is

1. in ADSREnvelope add a method called 'resetLevelAtAttack()' which does that
2. In SurgeSynthesizer where you get the nvoice stuff and getUnusedVoices, after the new( nvoice ) call if you are set grab the ampeg and call resetLevelAtAttack
3. Add a toggle

This one is tricky.

[baconpaul]

OK a bit more context on exactly how to do this

The action starts

surge/src/common/SurgeSynthesizer.cpp

Line 656 in 7c0d319

for (iter = voices[scene].begin(); iter != voices[scene].end(); iter++)

and moves out from there

That block is killing the old mono voice (the find and uber_release) and starting the new voice (the (nvoice) constructor call)

So what you want to do is

1. Add a new type to ADSREnvelope called StateCapture and add a getStateCapture and setToStateCapture method which you know, captures the state and resets the envelope to that captured state
2. Add a RMB which puts a bool on the scene storage for if you want to restart or recycle envelopes. Add the RMB to the poly menu. etc... and make sure to stream and unstream the bool with the version and son on
3. In the block linked above add a variable ADSR::StateCapture aeg_sc, feg_sc or what not and a bool which is that storage state
4. before the v->uber_reelase do aeg_sc = v->aeg.getStateCapture() and so on
5. After the nvoice initialization do v->aeg.setTOStateCapture and so on
6. Add a regtest that it works both ways
7. Debug, commit, win!