Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset name at the top of the window does not change ( until i close and reopen GUI).. i'm on FL STudio 20 on win10 #817

Closed
marlboonyer opened this issue Apr 5, 2019 · 19 comments · Fixed by #1842
Labels
Host Specific Issues related to specific host(s) or host features

Comments

@marlboonyer
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. windows 10]
  • Host [e.g. bitwig, logic]
  • Version [e.g. 2.4]

Additional context
Add any other context about the problem here.

@marlboonyer marlboonyer changed the title Preset change at the top of the window, does not change ( until i close and reopen GUI).. Preset name at the top of the window does not change ( until i close and reopen GUI).. i'm on FL STudio 20 on win10 Apr 5, 2019
@baconpaul
Copy link
Collaborator

Few questions

1: What version of surge are you running (what does help/about say)
2: How are you changing the preset? Like what action do you take to make the preset change?
3: And which name exactly isn't changing? Where at the top of the window?

I think you might mean "the name on the FL Studio Window Decoration" so you get a surge which says "FooBaz" in the patch browser but the FL Studio name is still "init". If that's the case I think this is a dup of #405

but if its something else please let us know!

@marlboonyer
Copy link
Author

marlboonyer commented Apr 5, 2019 via email

@baconpaul
Copy link
Collaborator

Thanks

Here’s the url without GitHub mangling it

https://snag.gy/lr8wYO.jpg

I’m not a fruity loops user. What is wrong with that screenshot? The patch name seems clearly displayed. Sorry it I am missing something obvious

@marlboonyer
Copy link
Author

marlboonyer commented Apr 6, 2019 via email

@baconpaul
Copy link
Collaborator

Huh wierd - obviously it changes for us!

Next time I fire up my windows vm I will take a look

Thanks!

@baconpaul
Copy link
Collaborator

FLPatch

OK that's a gif of me running the Surge VST3 in FL20 on Windows 10. Click the patch button or change the name with menu and it clearly changes.

So I guess I don't understand what the bug is. Do you see the same thing?

Thanks

@baconpaul baconpaul added the Host Specific Issues related to specific host(s) or host features label Apr 11, 2019
@baconpaul
Copy link
Collaborator

Hey just a note that @itsmedavep on slack said was able to wedge the Mac host into a similar state today - but we aren’t quite sure how yet. Tagging him here so he can add details when he has a chance

@itsmedavep
Copy link
Contributor

I see this too. I havent been able to nail down the exact steps as it seems somewhat intermittent.

Here is the detail:

Logic Pro X <- AU format plug

Surge (for my repro was built with this version baconpaul:render-with-svg)

Steps to repro (roughly):

  1. Zoom biggest
  2. Reset zoom to 100%
  3. Zoom biggest again

Periodically see this
zoom

For a while I was convinced that switching focus away from Surge and back after zooming contributed to the issue. Unfortunately, this one seems very intermittent so I can quite nail it down.

Screen Shot 2019-04-16 at 7 30 15 AM

Screen Shot 2019-04-16 at 7 30 32 AM

@baconpaul
Copy link
Collaborator

So I still can't reproduce this but looking at the code I do see a couple of places where maybe if your system was running the idle thread ahead of the patch load thread you could miss an update. I'll try and figure out an appropriate update.

baconpaul added a commit to baconpaul/surge that referenced this issue May 30, 2019
The patch display updates when queue_refresh is true but some
users report that it doesn't change when you pudate a patch.
That could happen if there is a race where the idle thread
runs ahead of the patch load thread, using the old version
but also resetting the refresh state. So add a third refresh
state which is "the patch browser id is not the synth id" which
forces a redraw.

May close the issue surge-synthesizer#817 but need user feedback.
baconpaul added a commit that referenced this issue May 30, 2019
The patch display updates when queue_refresh is true but some
users report that it doesn't change when you pudate a patch.
That could happen if there is a race where the idle thread
runs ahead of the patch load thread, using the old version
but also resetting the refresh state. So add a third refresh
state which is "the patch browser id is not the synth id" which
forces a redraw.

May close the issue #817 but need user feedback.
@baconpaul
Copy link
Collaborator

@marlboonyer as I noted on KVR also, I have put a change into the nightlies that, even though I can't reproduce this, fixes the one case I could see that might cause it. (Are you running on a lower power or smaller CPU count computer btw? That could lead to the race condition I see coming up more).

If you could try a nightly I would appreciate it. I want to cut 1.6.0 this weekend (and will include this change whether you test it or not) but would love to know if this fixes it for the release notes.

Thanks

@marlboonyer
Copy link
Author

i am not technically knowledgeable to answer some of your points.
all I can say is , i am on windows 10 running FL Studio 20 and when i change a preset via the Patch Browser at the top of the surge window the preset changes but the name does not.
when i close the window and then re-open it, the change IS displayed.
i also have a problem where i am unable to zoom the window other than it's default size. Even though it is obvious that i have plenty of space on the monitor..
if you require any technical info you'll have to give me instruction, i know nothing about coding ets..
marl

@baconpaul
Copy link
Collaborator

OK. Well tell you what I think I have a fix in 1.6.0 which I'm about to release. Why don't I do that, you download the new version, and then we revisit this if it is still broken. Sound good?

And thanks!

@marlboonyer
Copy link
Author

yep, no probs...

@baconpaul
Copy link
Collaborator

Oh and on the zoom thing: FL20 has a problem that VST2 can't zoom (technically the VST2 api does not support resizable UIs and FL is strict about that). If you want zoom in FL you should use the VST3.

@marlboonyer
Copy link
Author

for the life of me i don't know why i didn't see the vst3 version previously.
so, it works as expected in FL 20, the preset name changes. however the resizing issue remains.
i think that is down to my old monitors so it is probably not an issue for users with more current displays...

@baconpaul
Copy link
Collaborator

Is that with 1.6.0 or 1.6 beta 9? There are some changes for 1.6.0 which may help. But if you are on 1.6.0 can you give me a bit more idea about what the resize problem is? FL20 on Win10 is one of my "test occasionally" DAWs and I can resize pretty seamlessly in it with the VST3.

Thanks!

@marlboonyer
Copy link
Author

i installed your latest build earlier... vst2 still with preset name bug.
vst3 works fine.
this is the error i get when attempting to zoom:
"Surge limits zoom levels so as not to grow Surge larger than your available screen. Your screen size is 1024x768 and your target zoom os 125% would be too large.
Surge is choosing the largest fitting zoom 100%"

@baconpaul
Copy link
Collaborator

Oh right. So that's just us being conservative. We found that window decorations eat an unpredictable amount of space so we set max surge size to about 90% of pixel size available. In your case that means at 1024x768 (the screen size surge was originally designed for btw!) you don't get zoom alas.

Very useful to know that the VST2 is the one showing the preset name bug. I'll leave this open and try and reproduce it at some point. Appreciate that!

@baconpaul
Copy link
Collaborator

From KVR:

baconpaul wrote: ↑Sun Jun 09, 2019 5:02 pm
Dandruff wrote: ↑Sun Jun 09, 2019 4:54 pm
Another issue:

When the hosts audio engine isn't running, the Surge UI is not getting updated (when choosing different patch for example).
Thanks - can you let me know which daw which os and which host flavor? Then I’ll log it as a github issue unless you want to.
REAPER 5.978/x64 on Windows 8.1 Pro

Options/Preferences/Audio/Playback: Run FX when stopped = disabled

Just change a patch in Surge when playback is stopped and the track is not record/monitor-armed ...

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
The patch display updates when queue_refresh is true but some
users report that it doesn't change when you pudate a patch.
That could happen if there is a race where the idle thread
runs ahead of the patch load thread, using the old version
but also resetting the refresh state. So add a third refresh
state which is "the patch browser id is not the synth id" which
forces a redraw.

May close the issue surge-synthesizer#817 but need user feedback.

Former-commit-id: 260d4dfbf872c81463ea5deeb874d56790cba499 [formerly 1a4bca0]
Former-commit-id: 561ac8f8e3bf3021fff58c4301b279490a00d409
Former-commit-id: 28f095377379f1476febddf2fff2c6e30723d8f6
@baconpaul baconpaul added this to the 1.6.2 milestone Jul 19, 2019
@baconpaul baconpaul modified the milestones: 1.6.2, 1.6.3 Sep 9, 2019
@baconpaul baconpaul modified the milestones: 1.6.3, 1.6.n Oct 4, 2019
@baconpaul baconpaul modified the milestones: 1.6.n, Currently Unscheduled Oct 4, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue May 9, 2020
On patch change the synth properly invalidates, but
FL20 with VST2 has some sort of wierd thread-order bug
that means it didn't catch the update. Only FL20 and only
VST2. But hammer a change request at the end of patch
udpate for all hosts just to be sure.

Closes surge-synthesizer#817 as well, I bet
baconpaul added a commit that referenced this issue May 9, 2020
On patch change the synth properly invalidates, but
FL20 with VST2 has some sort of wierd thread-order bug
that means it didn't catch the update. Only FL20 and only
VST2. But hammer a change request at the end of patch
udpate for all hosts just to be sure.

Closes #817 as well, I bet
@mkruselj mkruselj removed this from the Currently Unscheduled milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Host Specific Issues related to specific host(s) or host features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants