-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preset name at the top of the window does not change ( until i close and reopen GUI).. i'm on FL STudio 20 on win10 #817
Comments
Few questions 1: What version of surge are you running (what does help/about say) I think you might mean "the name on the FL Studio Window Decoration" so you get a surge which says "FooBaz" in the patch browser but the FL Studio name is still "init". If that's the case I think this is a dup of #405 but if its something else please let us know! |
1. It is 1.6.0-beta-82. By selecting the preset drop down...3. As shown here: https://snag.gy/lr8wYO.jpghth,marl
On Friday, 5 April 2019, 22:21:18 BST, Paul <[email protected]> wrote:
Few questions
1: What version of surge are you running (what does help/about say)
2: How are you changing the preset? Like what action do you take to make the preset change?
3: And which name exactly isn't changing? Where at the top of the window?
I think you might mean "the name on the FL Studio Window Decoration" so you get a surge which says "FooBaz" in the patch browser but the FL Studio name is still "init". If that's the case I think this is a dup of #405
but if its something else please let us know!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks Here’s the url without GitHub mangling it I’m not a fruity loops user. What is wrong with that screenshot? The patch name seems clearly displayed. Sorry it I am missing something obvious |
The problem is when i select a different patch the name does NOT change. i know it's probably a small thing. that's how it has been for last few versions.
On Friday, 5 April 2019, 23:50:55 BST, Paul <[email protected]> wrote:
Thanks
Here’s the url without GitHub mangling it
https://snag.gy/lr8wYO.jpg
I’m not a fruity loops user. What is wrong with that screenshot? The patch name seems clearly displayed. Sorry it I am missing something obvious
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Huh wierd - obviously it changes for us! Next time I fire up my windows vm I will take a look Thanks! |
Hey just a note that @itsmedavep on slack said was able to wedge the Mac host into a similar state today - but we aren’t quite sure how yet. Tagging him here so he can add details when he has a chance |
I see this too. I havent been able to nail down the exact steps as it seems somewhat intermittent. Here is the detail: Logic Pro X <- AU format plug Surge (for my repro was built with this version baconpaul:render-with-svg) Steps to repro (roughly):
For a while I was convinced that switching focus away from Surge and back after zooming contributed to the issue. Unfortunately, this one seems very intermittent so I can quite nail it down. |
So I still can't reproduce this but looking at the code I do see a couple of places where maybe if your system was running the idle thread ahead of the patch load thread you could miss an update. I'll try and figure out an appropriate update. |
The patch display updates when queue_refresh is true but some users report that it doesn't change when you pudate a patch. That could happen if there is a race where the idle thread runs ahead of the patch load thread, using the old version but also resetting the refresh state. So add a third refresh state which is "the patch browser id is not the synth id" which forces a redraw. May close the issue surge-synthesizer#817 but need user feedback.
The patch display updates when queue_refresh is true but some users report that it doesn't change when you pudate a patch. That could happen if there is a race where the idle thread runs ahead of the patch load thread, using the old version but also resetting the refresh state. So add a third refresh state which is "the patch browser id is not the synth id" which forces a redraw. May close the issue #817 but need user feedback.
@marlboonyer as I noted on KVR also, I have put a change into the nightlies that, even though I can't reproduce this, fixes the one case I could see that might cause it. (Are you running on a lower power or smaller CPU count computer btw? That could lead to the race condition I see coming up more). If you could try a nightly I would appreciate it. I want to cut 1.6.0 this weekend (and will include this change whether you test it or not) but would love to know if this fixes it for the release notes. Thanks |
i am not technically knowledgeable to answer some of your points. |
OK. Well tell you what I think I have a fix in 1.6.0 which I'm about to release. Why don't I do that, you download the new version, and then we revisit this if it is still broken. Sound good? And thanks! |
yep, no probs... |
Oh and on the zoom thing: FL20 has a problem that VST2 can't zoom (technically the VST2 api does not support resizable UIs and FL is strict about that). If you want zoom in FL you should use the VST3. |
for the life of me i don't know why i didn't see the vst3 version previously. |
Is that with 1.6.0 or 1.6 beta 9? There are some changes for 1.6.0 which may help. But if you are on 1.6.0 can you give me a bit more idea about what the resize problem is? FL20 on Win10 is one of my "test occasionally" DAWs and I can resize pretty seamlessly in it with the VST3. Thanks! |
i installed your latest build earlier... vst2 still with preset name bug. |
Oh right. So that's just us being conservative. We found that window decorations eat an unpredictable amount of space so we set max surge size to about 90% of pixel size available. In your case that means at 1024x768 (the screen size surge was originally designed for btw!) you don't get zoom alas. Very useful to know that the VST2 is the one showing the preset name bug. I'll leave this open and try and reproduce it at some point. Appreciate that! |
From KVR: baconpaul wrote: ↑Sun Jun 09, 2019 5:02 pm When the hosts audio engine isn't running, the Surge UI is not getting updated (when choosing different patch for example). Options/Preferences/Audio/Playback: Run FX when stopped = disabled Just change a patch in Surge when playback is stopped and the track is not record/monitor-armed ... |
The patch display updates when queue_refresh is true but some users report that it doesn't change when you pudate a patch. That could happen if there is a race where the idle thread runs ahead of the patch load thread, using the old version but also resetting the refresh state. So add a third refresh state which is "the patch browser id is not the synth id" which forces a redraw. May close the issue surge-synthesizer#817 but need user feedback. Former-commit-id: 260d4dfbf872c81463ea5deeb874d56790cba499 [formerly 1a4bca0] Former-commit-id: 561ac8f8e3bf3021fff58c4301b279490a00d409 Former-commit-id: 28f095377379f1476febddf2fff2c6e30723d8f6
On patch change the synth properly invalidates, but FL20 with VST2 has some sort of wierd thread-order bug that means it didn't catch the update. Only FL20 and only VST2. But hammer a change request at the end of patch udpate for all hosts just to be sure. Closes surge-synthesizer#817 as well, I bet
On patch change the synth properly invalidates, but FL20 with VST2 has some sort of wierd thread-order bug that means it didn't catch the update. Only FL20 and only VST2. But hammer a change request at the end of patch udpate for all hosts just to be sure. Closes #817 as well, I bet
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: