Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Rotation Intervals display offset #7828

Closed
tank-trax opened this issue Oct 25, 2024 · 12 comments · Fixed by #7872
Closed

Scale Rotation Intervals display offset #7828

tank-trax opened this issue Oct 25, 2024 · 12 comments · Fixed by #7872
Labels
Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions UI Issues related to UI look&feel

Comments

@tank-trax
Copy link
Collaborator

I am not sure if this is intended or incorrect but it seems off.

The Scale Rotation Intervals displays a "0" for one column and removes the last note. In the case of 12 tET the column "12" that should be displaying 1200.0 is missing.

Screenshot_20241025_032707

The exported HTML however shows it in this manner.

Screenshot_20241025_032736

Could we get Scale Rotation Intervals display to mimic as it is in the exported HTML?

@tank-trax tank-trax added the Bug Report Item submitted using the Bug Report template label Oct 25, 2024
@Andreya-Autumn
Copy link
Collaborator

Interesting. Displaying degree 0 or the degree of the period is a choice and both are valid in different ways. But strange that we do a different thing in the export vs the editor.

@baconpaul
Copy link
Collaborator

It's different code - they share the tone center but not the layout calculation. We sh9ould just pick one and fix the other!

@tank-trax
Copy link
Collaborator Author

My proposal would be (using 12 tET as an example):

ScaleRotInt mod
DegsUnderRot

@mkruselj mkruselj added UI Issues related to UI look&feel Tuning Non-standard tuning extensions labels Oct 25, 2024
@mkruselj mkruselj added this to the Surge XT 1.4.0 milestone Oct 25, 2024
@baconpaul
Copy link
Collaborator

I think I did it this way to make the light up key gesture better. In your proposal the root key would not light up the first row but rather the last

@mkruselj
Copy link
Collaborator

Then maybe we tweak the HTML report to match how it is in Tuning Editor?

@tank-trax
Copy link
Collaborator Author

tank-trax commented Oct 25, 2024

I have an older build that has this. Not sure when the zeroes showed up but even this still seems wrong.

image

On Polar when the root is played both 0 and 12 (in a 12 note scale) light up.

image

@baconpaul
Copy link
Collaborator

The zeros showed up when I fixed your bug report on that build that the light up keys are off by one ;)

@tank-trax
Copy link
Collaborator Author

"fixed" ;-)

@baconpaul
Copy link
Collaborator

So do you want the root note of the scale to light up 12 in that case? Because that's what it would have to do.

That seemed wrong to me!

@tank-trax
Copy link
Collaborator Author

Not having the last note doesn't seem right.

@baconpaul
Copy link
Collaborator

Yeah you miss the repetition interval

so we can make it 1-12 and the root lights up 12 then

@tank-trax
Copy link
Collaborator Author

The other matrices, Intervals and To Equal, light up 0 for the root note. I wonder if illuminating 0 and 12 (last note) for the root note for all tables as is done on polar is too much?

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 29, 2024
1. Show 0..count like other views
2. make ti clear in rotation view that the 0 and 12 are non-editable

Closes surge-synthesizer#7828
baconpaul added a commit that referenced this issue Nov 29, 2024
1. Show 0..count like other views
2. make ti clear in rotation view that the 0 and 12 are non-editable

Closes #7828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions UI Issues related to UI look&feel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants