-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale Rotation Intervals display offset #7828
Comments
Interesting. Displaying degree 0 or the degree of the period is a choice and both are valid in different ways. But strange that we do a different thing in the export vs the editor. |
It's different code - they share the tone center but not the layout calculation. We sh9ould just pick one and fix the other! |
I think I did it this way to make the light up key gesture better. In your proposal the root key would not light up the first row but rather the last |
Then maybe we tweak the HTML report to match how it is in Tuning Editor? |
The zeros showed up when I fixed your bug report on that build that the light up keys are off by one ;) |
"fixed" ;-) |
So do you want the root note of the scale to light up 12 in that case? Because that's what it would have to do. That seemed wrong to me! |
Not having the last note doesn't seem right. |
Yeah you miss the repetition interval so we can make it 1-12 and the root lights up 12 then |
The other matrices, Intervals and To Equal, light up 0 for the root note. I wonder if illuminating 0 and 12 (last note) for the root note for all tables as is done on polar is too much? |
1. Show 0..count like other views 2. make ti clear in rotation view that the 0 and 12 are non-editable Closes surge-synthesizer#7828
1. Show 0..count like other views 2. make ti clear in rotation view that the 0 and 12 are non-editable Closes #7828
I am not sure if this is intended or incorrect but it seems off.
The Scale Rotation Intervals displays a "0" for one column and removes the last note. In the case of 12 tET the column "12" that should be displaying 1200.0 is missing.
The exported HTML however shows it in this manner.
Could we get Scale Rotation Intervals display to mimic as it is in the exported HTML?
The text was updated successfully, but these errors were encountered: