Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC (open sound control) - Solo button in mixer doesn't respond to OSC message. #7417

Closed
gitsmol opened this issue Dec 29, 2023 · 4 comments · Fixed by #7438
Closed

OSC (open sound control) - Solo button in mixer doesn't respond to OSC message. #7417

gitsmol opened this issue Dec 29, 2023 · 4 comments · Fixed by #7438
Labels
Bug Report Item submitted using the Bug Report template OSC Issues related to Open Sound Control (OSC) API UI Issues related to UI look&feel

Comments

@gitsmol
Copy link
Contributor

gitsmol commented Dec 29, 2023

Bug Description:
The solo button in the scene mixer doesn't respond to OSC messages.

Surge XT Version
Version: 1.3.0.20a8e16
Plugin Type: Standalone
Bitness: 64-bit

Reproduction Steps:
Send an OSC message to '/param/a/mixer/osc1/solo' with value 'True' or '1.0' (float). See also this python script:

from osc4py3.as_eventloop import *
from osc4py3 import oscbuildparse as obp
from osc4py3.oscmethod import *

def set_mute():
    msg = obp.OSCMessage("/param/a/mixer/osc1/solo", ",f", [False])
    osc_send(msg, "oscout")
    osc_process()

### config
ip = "127.0.0.1"
surgeOSCInPort = 53210	#Surge XT default OSC in port

osc_startup()
osc_udp_client(ip, surgeOSCInPort, "oscout")

set_mute()

osc_terminate()

Expected Behavior:
The selected channel is solo'ed.

Computer Information (please complete the following!):

  • OS: Mac OS 13.6.1
  • Host: Standalone

Additional Information:
The solo button does correctly send its value over OSC when it is changed. The mute button works fine.

@gitsmol gitsmol added the Bug Report Item submitted using the Bug Report template label Dec 29, 2023
@baconpaul
Copy link
Collaborator

Does it solo and the buttons are wrong or does it not solo?

@gitsmol
Copy link
Contributor Author

gitsmol commented Dec 29, 2023

Good question. It's only the button that doesn't light up; I tested with the noise generator and it does solo the channel, just doesn't show it.

@baconpaul
Copy link
Collaborator

Great then yeah I have a pretty good idea what this is. Thanks!

@mkruselj mkruselj added UI Issues related to UI look&feel OSC Issues related to Open Sound Control (OSC) API labels Jan 9, 2024
@mkruselj mkruselj added this to the Surge XT 1.3.1 milestone Jan 9, 2024
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 14, 2024
The solo button is non-local and so requires a rebuild when
it changes. The various mechanisms we have do this but OSC
did not. So start a list of param types which when OSC set
push a rebuild and add solo, mute, and scenesel all to them.

Closes surge-synthesizer#7417
@baconpaul
Copy link
Collaborator

and indeed that's what it was. Fixed in #7438 and a modified version of your script added to the repo. thanks!

baconpaul added a commit that referenced this issue Jan 14, 2024
The solo button is non-local and so requires a rebuild when
it changes. The various mechanisms we have do this but OSC
did not. So start a list of param types which when OSC set
push a rebuild and add solo, mute, and scenesel all to them.

Closes #7417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template OSC Issues related to Open Sound Control (OSC) API UI Issues related to UI look&feel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants