Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter analysis window: Filter 1 button appears hovered #7361

Closed
VincyZed opened this issue Dec 4, 2023 · 3 comments · Fixed by #7461
Closed

Filter analysis window: Filter 1 button appears hovered #7361

VincyZed opened this issue Dec 4, 2023 · 3 comments · Fixed by #7461
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.3.1

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Dec 4, 2023

After opening the filter analysis window, the Filter 1 button appears hovered, until you actually hover over it.
image
@VincyZed VincyZed added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template labels Dec 4, 2023
@VincyZed VincyZed added this to the Surge XT 1.3.1 milestone Dec 4, 2023
@baconpaul
Copy link
Collaborator

Spent a minute on this to see if it was something easy. And it is something obvious but not a pre-1.3. fix

basically MultiSwitch has a focus gained to do hovers which is fine and useful with keyboard nav

but showing here means element filter 1 gets focus and hovers due to that

so this intertwines with focus management and keyboard. not worth fixing this late

@baconpaul
Copy link
Collaborator

The ur-problem here is we don't have non-accessible overlays so the focus grab happens for no reason.

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 21, 2024
@baconpaul
Filter Analysis doesn't grab Kbd Focus on open
228e9d9 
This avoids a hover-paint on the filter 1 button when its neither
selected nor hovered. Since this is a non-accessible UI this
is basically what we want anyway.

Also make wantsInitialKeyboardFocus false.

Closes surge-synthesizer#7361
@baconpaul baconpaul mentioned this issue Jan 21, 2024
Merged
@baconpaul
Copy link
Collaborator

turns out i had solved this already for the scope. so now it is fixed here too.

baconpaul added a commit that referenced this issue Jan 21, 2024
@baconpaul
Filter Analysis doesn't grab Kbd Focus on open (#7461)
9a10fa8 
This avoids a hover-paint on the filter 1 button when its neither
selected nor hovered. Since this is a non-accessible UI this
is basically what we want anyway.

Also make wantsInitialKeyboardFocus false.

Closes #7361
This was referenced Mar 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.3.1
Development

Successfully merging a pull request may close this issue.

Filter Analysis doesn't grab Kbd Focus on open baconpaul/surge
2 participants
@baconpaul @VincyZed