Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Surge FX portable on windows ? #7278

Closed
geoslake opened this issue Oct 29, 2023 · 6 comments · Fixed by #7285
Closed

Is Surge FX portable on windows ? #7278

geoslake opened this issue Oct 29, 2023 · 6 comments · Fixed by #7285
Labels
Discussion
Milestone
Surge XT 1.3

Comments

@geoslake
Copy link

Hi

I know how to make Surge synth portable, but it seems Surge FX doesnt use the same folders (surgextdata & surgeuserdata), which makes sense of course. So, at least for the clap version, it recreates its own "surge xt" folder in $documents.
Is there a way to make it portable as well ?

Thanks a million !!
@baconpaul baconpaul added this to the Surge XT 1.3 milestone Oct 30, 2023
@baconpaul
Copy link
Collaborator

oh w e should just make it so it doesn't create the surge xt folder. it has no state to store and is fully encapsulated. Let me tag this int our 1.3 milestone.

(To answer your direct question it should search for the portable directory the same way surge does but I'll need to look at the code; and we can turn this off anyway - we do in rack - so should do so here)

@geoslake
Copy link
Author

geoslake commented Oct 30, 2023 •
edited
Loading

Hi Paul, thanks for replying and for your amazing work on Surge !!!
I guess Surge FX doesn't have any VC++ dependencies on Windows either (?)
Cos i remember you added the required dll to Surge Synth directly (its called static linking i think ?), not sure about FX but as im on a clean Windows 10 with nothing installed and FX just works....

@baconpaul
Copy link
Collaborator

that's right; all our MSVC compiled tools statically link the runtime.
surge fx needs nothing other than the vst3 file. just it uses a codepath which makes a documents directory regardless. we can fix that just requires a code change.

@geoslake
Copy link
Author

Ok, thank you very much Paul, and looking forward to the "fixes". Cheers

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 4, 2023
@baconpaul
CHange FX Processor Startup Path
01a6d04 
Change FX Processor startup path to use the new rack startup
path extensions; namely don't scan patches and wavetables and
dont create a documents directory if it doesn't exist

While there add a juce 7 version hint to the params to avoid

Closes surge-synthesizer#7278
a jassert
@baconpaul baconpaul mentioned this issue Nov 4, 2023
Merged
@baconpaul
Copy link
Collaborator

OK this fix will be in a nightly later today and in the 1.3 release this year.

baconpaul added a commit that referenced this issue Nov 4, 2023
@baconpaul
CHange FX Processor Startup Path (#7285)
a69c023 
Change FX Processor startup path to use the new rack startup
path extensions; namely don't scan patches and wavetables and
dont create a documents directory if it doesn't exist

While there add a juce 7 version hint to the params to avoid

Closes #7278
a jassert
@geoslake
Copy link
Author

geoslake commented Nov 5, 2023

thanks Paul !!

This was referenced Mar 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion
Projects
None yet
Milestone
Surge XT 1.3
Development

Successfully merging a pull request may close this issue.

CHange FX Processor Startup Path baconpaul/surge
2 participants
@baconpaul @geoslake