Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins parser produces "parse error" when encountering __MACOSX folders #7249

Closed
jolohaga opened this issue Oct 11, 2023 · 3 comments · Fixed by #7254
Closed

Skins parser produces "parse error" when encountering __MACOSX folders #7249

jolohaga opened this issue Oct 11, 2023 · 3 comments · Fixed by #7254
Labels
Bug Report Item submitted using the Bug Report template Skinning Engine Issues related to Surge's skin engine
Milestone

Comments

@jolohaga
Copy link

Bug Description:
When folders are zipped using the Finder, MacOS can add a __MACOSX folder to the contents of the zip archive. If such a zip file is passed to the skins parser, the parser will fail on the __MACOSX folder and issue a "parse error" message in the skins list.

Surge XT Version

  • Version: 1.2.3
  • Plugin Type: AU
  • Bitness: 32-bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Using Safari, download a skin archive from the library
  2. The download will be automatically unzipped. In the Finder find the download, right-click on it and select "Compress"
  3. In Surge, drag-and-drop the Finder zipped file
  4. Open the skins list and a list will appear tagged with "parse error". (see attached screenshot for an example)

Expected Behavior:
I expected to see a single set of skins to appear without "parse error" appearing.

Screenshots:
Screenshot 2023-10-10 at 6 45 04 PM

Computer Information (please complete the following!):

  • OS: MacOS Ventura 13.4.1
  • Host: Logic 10.7.9
  • Version: 10.7.9

Additional Information:
Please let me know if you need additional info. I can be reached in Discord.

@jolohaga jolohaga added the Bug Report Item submitted using the Bug Report template label Oct 11, 2023
@mkruselj mkruselj added this to the Surge XT 1.3 milestone Oct 11, 2023
@mkruselj mkruselj added the Skinning Engine Issues related to Surge's skin engine label Oct 11, 2023
@baconpaul
Copy link
Collaborator

Thanks. This will be easy to fix and I'll get it for 1.3. Excellent bug report. Appreciated.

@baconpaul
Copy link
Collaborator

Confirmed bug

@baconpaul
Copy link
Collaborator

Ahh there's two ways to solve it. The easy way is ignore __MACOSX directories form the zip file. The harder but better way is do that but also don't create them. I'll try and do both.

baconpaul added a commit to baconpaul/surge that referenced this issue Oct 14, 2023
the __MACOSX directory is special. juce zipfile doesn't treat
it as so. Now we do. Basically.

Closes surge-synthesizer#7249
baconpaul added a commit that referenced this issue Oct 14, 2023
the __MACOSX directory is special. juce zipfile doesn't treat
it as so. Now we do. Basically.

Closes #7249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Skinning Engine Issues related to Surge's skin engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants