Phase

[baconpaul]

Oh ha ha ha ha.
surge-synthesizer/surge-rack#937 (comment)

So this gave me an idea. The reason we haven't added initial phase to surge is a couple of fold, but one of them is there's no place for a param. But there is a place in teh API. And we want this for XT2. So I could quite easily do this

1. Change oscillator::init to have a float initialPhase=0 argument
2. Visit all the oscillators and implement it. Implementing it is trivial.
3. Don't expose that to the surge VST in the 1.x series. Sorry. Sucks to be you VST users
4. But expose it in the rack modules since they call ::init directly and aren't bound by the param infrastructure in the same way then
5. In XT2 add a initial-phase param which just blats onto that setting

[mkruselj]

We actually have issue #867 for this, hehe 🙂

[baconpaul]

Yeah I was gonna find that

that’s for phase in surge and so should stay open even once this is closed but it will be way easier once I do this!